DBC22-6551/DBC22-5139: Move maint page to react and move env variables to index - #1352
Merged
Conversation
bcgov-brwang
reviewed
Jun 1, 2026
bcgov-brwang
left a comment
Collaborator
There was a problem hiding this comment.
I have some concerns about the environment variables that appear in the index scripts. Does this mean that those credentials could potentially be exposed?
Collaborator
Author
These are all public ones. If you go to the main.js in prod right now, you will see them at the very bottom. This just moves them to the index.html file which is not cached (unlike main.js which is). So in the case of env variable changes, users will now get them immediately instead of waiting for the cache to expire. |
bcgov-brwang
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Submitter
🔗 JIRA Ticket
✅ Quality Assurance & Requirements
⚙️ Configuration & Environment
🧪 How to Test (if required)
MAINTENANCE_MODEto trueTesting the Env variable change
🔍 Reviewer Checklist